Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/signalfx] Add an option to control the dimension client timeout #27815

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

dloucasfx
Copy link
Contributor

Description:
The dimension client timeout is currently hardcoded to 10 seconds, this PR makes the timeout configurable.

Link to tracking Issue:

Testing:
Unit test
Documentation:
Update Readme

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the option to the README as well

…eout

Signed-off-by: Dani Louca <dlouca@splunk.com>
@atoulme
Copy link
Contributor

atoulme commented Oct 19, 2023

Addressing failing build in #27869

@dmitryax dmitryax merged commit 1d2be84 into open-telemetry:main Oct 20, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 20, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…eout (open-telemetry#27815)

**Description:** 
The dimension client timeout is currently hardcoded to 10 seconds, this
PR makes the timeout configurable.

Signed-off-by: Dani Louca <dlouca@splunk.com>
Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…eout (open-telemetry#27815)

**Description:** 
The dimension client timeout is currently hardcoded to 10 seconds, this
PR makes the timeout configurable.

Signed-off-by: Dani Louca <dlouca@splunk.com>
Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants